Skip to content

Commit

Permalink
chore: skip regression tests from v1.61.1 series (aws#10147)
Browse files Browse the repository at this point in the history
We introduced constraints on the bootstrap qualifier and updated the
tests to pass a shorter qualifier--but the old integretion tests
obviously still pass the long qualifier so now the old tests fail
against the new CLI.

Skip the offending tests.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
rix0rrr authored Sep 3, 2020
1 parent 327b72a commit b757d88
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 0 deletions.
6 changes: 6 additions & 0 deletions packages/aws-cdk/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ To run a single integ test in the source tree:
$ test/integ/run-against-repo test/integ/cli/test.sh -t 'SUBSTRING OF THE TEST NAME'
```

To run regression tests in the source tree:

```
$ test/integ/test-cli-regression-against-current-code.sh [-t '...']
```

### CLI integration tests

CLI tests will exercise a number of common CLI scenarios, and deploy actual
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Introduced a limitation on bootstrapping qualifier length
(max 10 chars) but old tests were using qualifiers of 12 chars.
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# This file is empty on purpose. Leave it here as documentation
# and an example.
#
# Copy this file to cli-regression-patches/vX.Y.Z/skip-tests.txt
# and edit it there if you want to exclude certain tests from running
# when performing a certain version's regression tests.
#
# Put a test name on a line by itself to skip it.

upgrade legacy bootstrap stack to new bootstrap stack while in use
deploy new style synthesis to new style bootstrap
deploy new style synthesis to new style bootstrap (with docker image)
deploy old style synthesis to new style bootstrap
can dump the template, modify and use it to deploy a custom bootstrap stack
switch on termination protection, switch is left alone on re-bootstrap
add tags, left alone on re-bootstrap

0 comments on commit b757d88

Please sign in to comment.