fix(meta): unregister aborted initial job tables#25604
Open
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR is scoped to DDL abort cleanup for creating streaming jobs. It does not change per-database dirty-job recovery cleanup; that path is fixed separately in #25592.
Bug:
create_streaming_job_inneraborts the creating job withis_cancelled = false.DROP/CANCELof anInitialjob also aborts through the same catalog helper.Fix:
AbortCreatingStreamingJobResultfromtry_abort_creating_streaming_job, including the aborted job's state table ids.Fragment.state_table_ids, and the MV table catalog.Fragment.state_table_idsis needed because the SQL/simulation repro registers table ids through fragment metadata that are not fully represented byget_internal_tables_by_id.DROP/CANCELofInitialjobs throughcleanup_dropped_streaming_jobs, so Hummock unregister and Hummock/compactor notification happen through the existing dropped-table cleanup path.Background/Creatingrecovery unchanged.Not covered by this PR:
Testing
cargo fmt --all -- --checkgit diff --checkcargo check -p risingwave_meta --libcargo test -p risingwave_meta test_abort_initial_materialized_views_unregister_hummock --lib -- --nocapture./risedev sit-test test_per_db_recovery_abort_failed_foreground_ddl_unregisters_hummock_tables --no-captureChecklist
Documentation
Release note
Fixed stale Hummock table ids that can remain after aborting a creating streaming job in the DDL path.