Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable parallel frontend for rustc #19331

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Conversation

BugenZhao
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Enables the experimental parallel frontend feature for rustc under dev profile. For references, see https://blog.rust-lang.org/2023/11/09/parallel-rustc.html.

This reduces the time of incremental check from 30s to 18s with Apple M4 Pro. The major improvement is that the bottleneck of risingwave_meta spends significantly less time with parallel frontend.

Prev:
image

After:
image

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also check full compilation with risingwave crates?

delete and rebuild

find target -name '*risingwave*' -type d -exec rm -rf {} + -o -name '*risingwave*' -delete

@BugenZhao
Copy link
Member Author

can you also check full compilation with risingwave crates?

Sure. From 64.6s to 39.7s

image image

@BugenZhao BugenZhao added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 12fbf12 Nov 12, 2024
28 of 29 checks passed
@BugenZhao BugenZhao deleted the bz/rustc-parallel-frontend branch November 12, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants