fix(agg): fix first_value and last_value to not ignore NULLs

[stdrc]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

To align behavior with PG, we should not ignore NULLs when computing first_value and last_value.

This PR affects batch aggregate, batch over window. Also, a previous PR #19233 has already changed the behavior of streaming over window to the correct one.

Fixes #18927.

Checklist

• I have written necessary rustdoc comments
• I have added necessary unit tests and integration tests
• I have added test labels as necessary. See details.
• I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
• My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
• All checks passed in ./risedev check (or alias, ./risedev c)
• My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

• My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

• My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

[stdrc]

• perf(agg expr): use short_if for append only bool_and and bool_or aggregation #19330
• fix(agg): fix first_value and last_value to not ignore NULLs #19275 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stdrc and the rest of your teammates on Graphite

[BugenZhao]

Is this considered a breaking change? Do we use them internally as well?

[stdrc]

The initial fix is not correct for first_value because of the internal mechanism of aggregate macro. Later commits introduced a new short_if macro argument so that first_value can be implemented via immediate shortcurcuiting.

[stdrc]

Superseded by #19332