-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(subscription): support cusor order #18801
Conversation
90eb58a
to
ffa9dfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline: we can support explain fetch ... <cursor>
in this PR so that we can understand more about the batch query plan.
@@ -351,6 +351,7 @@ impl SubscriptionCursor { | |||
expected_timestamp, | |||
init_query_timer, | |||
}; | |||
println!("fields: {:?},???,{:?}", fields, self.fields); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
fe337c4
to
5bcb09b
Compare
5bcb09b
to
f5bd469
Compare
@@ -89,7 +89,7 @@ impl Distill for BatchLogSeqScan { | |||
vec.push(("distribution", dist)); | |||
} | |||
|
|||
childless_record("BatchScan", vec) | |||
childless_record("BatchLogSeqScan", vec) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include the epoch range and version id in the result as well.
It seems that the ordering doesn't work. Example:
|
.flatten_unordered(1024), | ||
}; | ||
// All need merge | ||
_ => merge_sort(iterators.into_iter().map(Box::pin).collect()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the normal batch iterator, can we have a ordered
option to determine whether merge_sort
is needed?
See
let ordered = seq_scan_node.ordered; |
_ if !ordered => { |
fix comm snapshot not merge
d8199b5
to
bd64ded
Compare
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9425213 | Triggered | Generic Password | b96f3e2 | risedev.yml | View secret |
9425213 | Triggered | Generic Password | b96f3e2 | e2e_test/source_inline/tvf/postgres_query.slt | View secret |
9425213 | Triggered | Generic Password | b96f3e2 | e2e_test/source_inline/tvf/postgres_query.slt | View secret |
9425213 | Triggered | Generic Password | b15cee9 | ci/scripts/e2e-source-test.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM!
@@ -126,6 +129,8 @@ impl TryToBatchPb for BatchLogSeqScan { | |||
}, | |||
)), | |||
}), | |||
// It's currently true. | |||
ordered: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this consistent with BatchSeqScan:
ordered: !self.order().is_any()
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
#18208
In this pr, we'll make sure that the results returned by cursor are sorted by pk, making sure that we return the results in only one order, this is in order to later use pk+rw_timestamp+op to implement the cursor Exactly Once
And support
explain fetch n from subscription cursor
will return the batch plan of subscription cursorChecklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.