-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support TPC-H Q9 #761
Conversation
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Q9 contains a lot of joins, and I guess we need to see if the join order is not optimal.
Any idea about the failing CI? I can't get the point from the error message: 🥵
|
I guess it’s OOM or something… |
I believe it's OOM because it consumes 16GB on my Mac. |
Signed-off-by: Runji Wang <wangrunji0408@163.com>
With subquery support in #756, we are able to challenge more TPC-H queries.
As an example, this PR adds support for TPC-H Q9.
Changes:
like
operatorextract(year from xx)
functionsqlparser-rs
version to 0.30 (for derivingOrd
)However, the speed for this query is ridiculously slow. (104s vs DuckDB <1s)
We should investigate and optimize it in the future.