Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable query engine v2 by default #729

Merged
merged 9 commits into from
Nov 10, 2022
Merged

chore: enable query engine v2 by default #729

merged 9 commits into from
Nov 10, 2022

Conversation

wangrunji0408
Copy link
Member

@wangrunji0408 wangrunji0408 commented Nov 10, 2022

As the final step to introduce the new planner #703, this PR reorganizes code structures, moves the legacy binder/planner/optimizer/executor to the v1 module, and enables v2 by default. The legacy modules will be kept for a while, as a reference to improve the new one further. But it's not expected to add new features to it.

Here is a rough statistic to compare the lines of code of the two versions:

Module v1 v2
Binder 2071 1115
Planner 4731 1411
Executor 2258* 1307
Total 9060 3833

* exclude unused executors
* use loc to count lines of code

Even taking into account the lack of test code in v2 for now, it is still much simpler than v1, using half of the code to achieve the same goal. Thanks to egg, we can make RisingLight lite again!

Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
@wangrunji0408 wangrunji0408 requested a review from skyzh November 10, 2022 03:32
@wangrunji0408 wangrunji0408 linked an issue Nov 10, 2022 that may be closed by this pull request
14 tasks
@wangrunji0408 wangrunji0408 enabled auto-merge (squash) November 10, 2022 03:40
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
@wangrunji0408 wangrunji0408 merged commit eb9251b into main Nov 10, 2022
@wangrunji0408 wangrunji0408 deleted the wrj/v2 branch November 10, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking: next-gen planner & optimizer
2 participants