fix: voxtral duration comparison and "auto" language handling#380
Open
peterjs wants to merge 1 commit intorishikanthc:mainfrom
Open
fix: voxtral duration comparison and "auto" language handling#380peterjs wants to merge 1 commit intorishikanthc:mainfrom
peterjs wants to merge 1 commit intorishikanthc:mainfrom
Conversation
- use shared LANGUAGES constant in frontend config dialog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: voxtral duration comparison and "auto" language handling
Duration Logic: Fixed a bug where duration was compared in nanoseconds. Comparing against 30*60 caused the value to always be smaller, forcing Voxtral python code to start in buffered mode even shorter recordings.
Removed passing "auto" language down the python code. When no argument is passed, it is considered to be auto. transformers/Voxtral (mistral_common) uses Pydantic to enforce LanguageAlpha2 types, which "auto" violates. The system however accepts any standard ISO language code, therefore I replaced the custom VOXTRAL_LANGUAGES array in the UI with the shared LANGUAGES array.