Skip to content

Commit

Permalink
Merge pull request vitessio#2068 from alainjobart/reparent
Browse files Browse the repository at this point in the history
Adding more logging in external reparent.
  • Loading branch information
alainjobart authored Sep 20, 2016
2 parents 7548df3 + 0103f3f commit 05b785b
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions go/vt/tabletmanager/rpc_external_reparent.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
)

var (
finalizeReparentTimeout = flag.Duration("finalize_external_reparent_timeout", 10*time.Second, "Timeout for the finalize stage of a fast external reparent reconciliation.")
finalizeReparentTimeout = flag.Duration("finalize_external_reparent_timeout", 30*time.Second, "Timeout for the finalize stage of a fast external reparent reconciliation.")

externalReparentStats = stats.NewTimings("ExternalReparents", "NewMasterVisible", "FullRebuild")
)
Expand Down Expand Up @@ -174,7 +174,9 @@ func (agent *ActionAgent) finalizeTabletExternallyReparented(ctx context.Context
// Tell the old master to re-read its tablet record and change its state.
// We don't need to wait for it.
tmc := tmclient.NewTabletManagerClient()
tmc.RefreshState(ctx, oldMasterTablet)
if err := tmc.RefreshState(ctx, oldMasterTablet); err != nil {
log.Warningf("Error calling RefreshState on old master %v: %v", topoproto.TabletAliasString(oldMasterTablet.Alias), err)
}
}()
}

Expand Down

0 comments on commit 05b785b

Please sign in to comment.