Fix contradictory req. for ndmresetpending #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdonahue-ventana
approved these changes
Jan 11, 2024
Conflicts: debug_module.tex
rtwfroody
force-pushed
the
fix-contradictory-ndmresetpending-requirements
branch
from
bd154a5
to
74dbb5b
Compare
|
The asciidoc merge caused conflicts. I rebased the branch onto it. @JanMatCodasip can you confirm that this is still the same change? |
|
@JanMatCodasip: Can you confirm that this PR is still what you were proposing? If so, I think that we can merge this PR that came from the public review process. |
|
@rtwfroody, @pdonahue-ventana I am sorry for my delayed reply. Yes, the current change is all right and corresponds to the original proposal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definition of
dmstatus.ndmresetpendingbit says that this bit should be equal to 1 whiledmcontrol.ndmresetis asserted, implying thatdmstatus.ndmresetpendingis readable even under ndmreset.Therefore, this merge request updates the text that specifies which DM register accesses are defined under ndmreset.
The change has been discussed here: #944