This repository has been archived by the owner on Jan 16, 2023. It is now read-only.
Bump OpenOCD for SBA Option command #185
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsifive
approved these changes
Mar 27, 2018
|
What about this commit? It looks OpenOCD related... riscv-collab/riscv-gnu-toolchain@1b80cbe Just trying to get to a clean place where OpenOCD/GDB work nicely together. |
|
On Tue, Mar 27, 2018 at 11:14 AM, Megan Wachs ***@***.***> wrote:
What about this commit? It looks OpenOCD related...
***@***.***
<riscv-collab/riscv-gnu-toolchain@1b80cbe>
This is only needed if you try to canadian cross build a native riscv64
compiler. None of our build scripts do that. I only noticed it by
accident when I was testing unused Makefile rules to see what they do.
Jim
|
|
I always order my commits so that at any time the latest version of OpenOCD works with the latest version of GDB, works with riscv-tests. If that's not possible I'll commit them close together in time, but I don't remember having to do that in quite a while. |
|
On Tue, Mar 27, 2018 at 11:14 AM, Megan Wachs ***@***.***> wrote:
@mwachs5 <https://github.com/mwachs5> requested your review on:
riscv-software-src/riscv-tools#185 <#185>
Bump OpenOCD for SBA Option command.
I don't know anything about OpenOCD. You have to have access to hardware
to use it, and I don't have access to hardware.
Jim
|
mwachs5
force-pushed
the
openocd_sba_option
branch
from
37d081b to
249eac3
Compare
|
Since #190 is still failing I am attempting to just bump OpenOCD for the Prefer SBA command that I need. FYI @rmac-sifive. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do I need to make any corresponding changes to
riscv-isa-simorriscv-tests, since OpenOCD hasn't been bumped in a while? Or toGDB?