Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target/riscv: vector CSRs are optional #1093

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

en-sc
Copy link
Collaborator

@en-sc en-sc commented Jun 25, 2024

This is a fix to a mistake made in
ea7e174.

The newly introduced gdb_regno_exist() function was missing a part regarding vector CSRs:
ea7e174#diff-b4aa16f9e42cb8f0934baa7c8e0ec9c70a369bef98b99b26ae2e896c8aa95d6aL6163-L6171

Change-Id: I0361ea4dce8df5be748e2c6e7e6838029d3a7120

@en-sc en-sc requested review from MarekVCodasip and JanMatCodasip and removed request for MarekVCodasip June 25, 2024 11:29
@en-sc en-sc self-assigned this Jun 25, 2024
JanMatCodasip
JanMatCodasip previously approved these changes Jul 2, 2024
Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is a fix to a mistake made in
ea7e174.

The newly introduced `gdb_regno_exist()` function was missing a part
regarding vector CSRs.
Link: riscv-collab@ea7e174#diff-b4aa16f9e42cb8f0934baa7c8e0ec9c70a369bef98b99b26ae2e896c8aa95d6aL6163-L6171

Change-Id: I0361ea4dce8df5be748e2c6e7e6838029d3a7120
Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
@en-sc en-sc merged commit 57d2553 into riscv-collab:riscv Jul 9, 2024
4 checks passed
@en-sc en-sc deleted the en-sc/v-ext-csrs branch July 9, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants