Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB3-336: chore: Enable keccak precompile in examples #432

Merged
merged 4 commits into from
Feb 1, 2025

Conversation

Wollac
Copy link
Contributor

@Wollac Wollac commented Jan 31, 2025

No description provided.

@Wollac Wollac requested a review from a team as a code owner January 31, 2025 11:27
@github-actions github-actions bot changed the title chore: Enable keccak precompile in examples WEB3-336: chore: Enable keccak precompile in examples Jan 31, 2025
Copy link
Contributor

@nategraf nategraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this improve performance in the case of making just a few SLOADs?

@Wollac
Copy link
Contributor Author

Wollac commented Feb 1, 2025

Does this improve performance in the case of making just a few SLOADs?

I did some very rough benchmarks on this and at least for the smallest realistic use cases (like loading a single account from Sepolia) it is still a significant speedup (almost 3x). I haven't benchmarked artificial cases like an Anvil with only a single account with empty state or anything like that, but this seems to be enough to add it to the examples and recommend it.

@Wollac Wollac merged commit d23a551 into main Feb 1, 2025
11 checks passed
@Wollac Wollac deleted the chore/keccak-precompile branch February 1, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants