WEB3-151: Use builder also for beacon input #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wollac
force-pushed
the
feat/parent-beacon-root
branch
from
940864d to
58f0fb1
Compare
Wollac
force-pushed
the
feat/beacon-builder
branch
from
c6682b1 to
0638b73
Compare
|
To be merged after #265 |
capossele
approved these changes
Oct 4, 2024
Wollac
force-pushed
the
feat/beacon-builder
branch
from
0638b73 to
82a0ddf
Compare
github-actions
bot
changed the title
nategraf
approved these changes
Oct 7, 2024
Wollac
added a commit
that referenced
this pull request
Oct 7, 2024
Previously, an input with a Beacon root commitment was created using the `into_beacon_input` method of the environment. This is inconsistent as all configuration should happen in the `EvmEnvBuilder`. Resolves #259 Resolves WEB3-151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, an input with a Beacon root commitment was created using the
into_beacon_inputmethod of the environment. This is inconsistent as all configuration should happen in theEvmEnvBuilder.Resolves #259
Resolves WEB3-151