Add Zirgen-based acceleration #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdg744
reviewed
Nov 7, 2024
flaub
reviewed
Nov 7, 2024
| @@ -1,3 +1,4 @@ | |||
| #[allow(unused_imports)] | |||
Author
There was a problem hiding this comment.
My hypothesis was that upstream was only warning on unused_imports whereas the risc0 repo has it set to error. But I'm not very familiar with how Rust warning/error settings work so I'm not sure if this sort of cross-crate setting contamination can even happen.
flaub
reviewed
Nov 7, 2024
flaub
approved these changes
Nov 7, 2024
austinabell
added a commit
that referenced
this pull request
Dec 13, 2024
Use the new RSA extern (#2) --------- Co-authored-by: Frank Laub <github@frank.laub.io> Use risc0-bigint2 (#3) * Use risc0-bigint2 * Use num-bigint-dig feature * Update lockfile * Update ref * Update ref * Update git ref Update bigint2 impl with 4096 bit support (#4) * update acceleration to use latest version of bigint2 (with 4096 bit support) * bump version * bump to 1.2
austinabell
added a commit
that referenced
this pull request
Dec 13, 2024
* Add Zirgen-based acceleration (#1) Use the new RSA extern (#2) --------- Co-authored-by: Frank Laub <github@frank.laub.io> Use risc0-bigint2 (#3) * Use risc0-bigint2 * Use num-bigint-dig feature * Update lockfile * Update ref * Update ref * Update git ref Update bigint2 impl with 4096 bit support (#4) * update acceleration to use latest version of bigint2 (with 4096 bit support) * bump version * bump to 1.2 * gate prop tests behind cfg to enable cargo risczero test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of the RSA acceleration from risc0/risc0#2481 when run in the RISC Zero guest.
Can't land until risc0/risc0#2481 lands.