Skip to content

Conversation

@Mikel-Landa
Copy link
Contributor

Fixes #163

@ripytide
Copy link
Owner

The issue for this is #164, and @thehaseebahmed asked very nicely to take on this issue only yesterday. You might not have seen that since it's in #164 and not mentioned on #163 but I did link in #163 to #164 so it was quite easy to follow the link and see. As such I think this is quite poor etiquette.

I'm going to leave this for a while to give @thehaseebahmed a chance to submit any work they've done.

@thehaseebahmed
Copy link

it's alright, I was going to do it over the weekend but if someone beat me to it... it is what it is but thank you for being so considerate!

@Mikel-Landa
Copy link
Contributor Author

it's alright, I was going to do it over the weekend but if someone beat me to it... it is what it is but thank you for being so considerate!

Sorry about that you can take it, didn't see the issue.

@Mikel-Landa
Copy link
Contributor Author

The issue for this is #164, and @thehaseebahmed asked very nicely to take on this issue only yesterday. You might not have seen that since it's in #164 and not mentioned on #163 but I did link in #163 to #164 so it was quite easy to follow the link and see. As such I think this is quite poor etiquette.

I'm going to leave this for a while to give @thehaseebahmed a chance to submit any work they've done.

Wouldn't say it's poor etiquete, just a well-intentioned mistake... I'm not following these issues not it's my repository so I don't notice when you edit or add a comment.

@thehaseebahmed
Copy link

it's alright, I was going to do it over the weekend but if someone beat me to it... it is what it is but thank you for being so considerate!

Sorry about that you can take it, didn't see the issue.

No worries! You've already done the work so no point in wasting effort. All good here, no hard feelings 😁

@ripytide
Copy link
Owner

All is well that ends well, glad this worked out. I'll start reviewing this then.

@ripytide ripytide merged commit ab1f1e0 into ripytide:main Nov 14, 2025
5 checks passed
@Mikel-Landa Mikel-Landa deleted the feature/merge-backend-configs branch December 4, 2025 09:02
@ripytide
Copy link
Owner

Released in v0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants