Add mise backend #166
Add mise backend #166
Conversation
Mikel-Landa
changed the title
|
@ripytide any other issues? |
src/backends/mise.rs
Outdated
| pub struct MiseOptions { | ||
| requested_version: Option<String>, | ||
| active: Option<bool>, | ||
| #[serde(default)] | ||
| version: Option<String>, |
There was a problem hiding this comment.
@ripytide why change this? This means that pre-installed mise packages, when performing metapac unmanaged will get pinned down to their current version, irrespective of the user's specification (e.g will get version x.y.z instead of latest or lts) and removing the use command means that for a new machine the users will need to activate each binary manually
There was a problem hiding this comment.
All options should be Option since they are optional in group files which is what this struct represents. As for active I read the difference between mise install and mise use and the only difference was that use adds the package to the mise.toml but as mentioned previously the mise.toml file doesn't make sense if you are using metapac. Happy to discuss this more though.
There was a problem hiding this comment.
From their docs:
meaning that installing it will not add it to the PATH and it won't be available for the user. All good for the options, the other questions was about changing requested_version to version having the consequences described above.
There was a problem hiding this comment.
Okay, interesting, so we should always be doing mise use rather than mise install since then installed packages get added to the PATH? So that'll mean we still need the --global flag too then. Can you make another PR to fix these issues in the mise backend?
2 participants
Addresses #127