persist validations inside the db #373
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Store the validation messages inside the database. If the VHS-connections service is down, then the persisted validation-messages can be used to accurately calculate the agreement scores. At the present time, the validations are only stored inside the ephemeral RAM memory, which is vulnerable to data loss during pod restarts.
Context of Change
Type of Change
Before / After
This PR only stores the validations inside the database. No change has been made to the agreement-score calculation logic yet.
Test Plan
Appropraite unit tests have been added.
Future Tasks
KnexPoolTimeout(or similar errors), then the initial Knex config needs to be updated to a suitable value. Depending on the deployment machine hardware configuration and the needs of the VHS-connections service, we need to set a suitablemaxsize for the database connections pool.Please read this document before suggesting a very high max-connections number.