Multilingual version #144
Open
Multilingual version #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! I hope to take a look later this week. |
Luisetelo
reviewed
Aug 8, 2017
| @@ -67,20 +72,23 @@ class DateTimePicker extends Events { | |||
| // style options | |||
| initializeRome(container, validator) { | |||
| const onData = this.onChangeDate.bind(this); | |||
|
|
|||
| const weekDays = moment.localeData(this.options.locale)._weekdaysMin; | |||
There was a problem hiding this comment.
@Luisetelo this solution was used due to the version of moment.js this project uses.
|
This looks good, any ideia when we can get it merged in, @joews? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on another PR (#129), which was merged to version 2.3.0 but was removed in version 2.4.0, support for locale language was added. Also comparing to previous PR, this one translates not only names for days of week, but also months and time units. All user has to do is to pass 'locale' parameter when initializing MaterialDateTimePicker. Also unlike previous PR, this one uses the same version of moment.js