Skip to content
This repository has been archived by the owner on Apr 21, 2022. It is now read-only.

Correctly handle RSA keys generated by latest OpenSSH #31

Closed
blackandred opened this issue Nov 11, 2020 · 1 comment
Closed

Correctly handle RSA keys generated by latest OpenSSH #31

blackandred opened this issue Nov 11, 2020 · 1 comment
Assignees
@blackandred
Milestone
Harbor 2.1

Comments

@blackandred
Copy link
Contributor

Issue: Not all keys begins with -----BEGIN OPENSSH PRIVATE KEY, some begins with -----BEGIN RSA PRIVATE KEY which makes Harbor not to recognize value as a properly formatted private key. The result is that key is pasted into ansible.cfg making a syntax issue.

Resolution: check only first -----BEGIN at the at least beginning of the private key string
@blackandred blackandred added this to the Harbor 2.1 milestone Nov 11, 2020
@blackandred blackandred self-assigned this Nov 11, 2020
@blackandred
Copy link
Contributor Author

Done

blackandred added a commit that referenced this issue Nov 11, 2020
@blackandred
#31: Consider also keys with -----BEGIN RSA PRIVATE KEY header
6d27ece
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@blackandred blackandred

Labels
None yet
Projects
None yet
Milestone
Harbor 2.1
Development

No branches or pull requests
1 participant
@blackandred