Fix AEAD stream writer to write a big chunk buffer #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! Thanks for the PR! Could you please send the PR to the stable repo at shadowsocks/go-shadowsocks2 as well? This repo and the one at shadowsocks/go-shadowsocks2 have diverged since this repo is experimental for my personal use cases, and the stable repo needs to be, well, stable for the public. Some features are not suitable and/or mature enough to be upstreamed to the stable repo. If you want stability and better support, please use that one. |
|
|
|
Ah, right! There was a refactor that changed the exposed API of this repo… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I used
riobard/go-shadowsocks2as an ss-client in my project and I wrapper anet.ConnafterStreamConnwithoutWriteToandReadFrom.Then I use
io.Copywith two TCP connection. In AEAD cipher, I found out that the connection closes when to upload some images. TheWriteris not written correctly when writing a big buffer.Question
When I discovered this bug, I assumed that
shadowsocks/go-shadowsocks2had the same bug. But when I went to check, I found a big gap between the two implementations. So the two repositories are completely forked?