[MessageTrait] Fix withAddedHeader() with array $value#4
Merged
kirill-konshin merged 1 commit intoringcentral:masterfrom Jan 15, 2018
Conversation
Contributor
Author
|
Failed Travis build should be fixed by #5 |
clue
approved these changes
Jan 13, 2018
Contributor
clue
left a comment
There was a problem hiding this comment.
Good catch, thank you for looking into this! 👍
Contributor
|
Pls rebase and re run the tests |
0f12101 to
dcf104b
Compare
Contributor
Author
@kirill-konshin done |
Contributor
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue when
withAddedHeader()'s input param$valueis an array. After the changes in this pull request, output will match Guzzle's and Diactoros' output.Issue example:
Issue example output: