Support legacy PHP 5.3#1
Merged
kirill-konshin merged 1 commit intoringcentral:masterfrom Mar 25, 2016
Merged
Conversation
Contributor
|
Thanks! |
Contributor
Author
|
Thanks for quick reaction @kirill-konshin! Is there an ETA for the next tag so I can start relying on this? |
Contributor
|
Released 1.2.1. But I strongly recommend to upgrade your version of PHP and stick to original repo, since I don't have any major plans on supporting this fork... Only urgent bugfixes. |
Contributor
Author
|
Thanks for the heads up! Unfortunately the upstream maintainer has expressed little interest in supporting legacy PHP versions (which I fully understand and accept), so I'll have to build this on top of this for now. |
Contributor
|
That was the reason why I forked it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This (trivial) change allows this library to be used with even older versions of PHP. Note that they may be EOL'ed by Zend, but they're still supported by many common distros / vendors.
Not sure why this was limited to 5.3.29 initially, but I've confirmed this to work with at least 5.3.10 (PHP version in use by Ubuntu 12.04) and possibly below.