Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tsf): accomplish candidate UI interfaces #156

Merged
merged 23 commits into from
Mar 31, 2018
Merged

feat(tsf): accomplish candidate UI interfaces #156

merged 23 commits into from
Mar 31, 2018

Conversation

nameoverflow
Copy link
Member

@nameoverflow nameoverflow commented Mar 25, 2018 •
edited
Loading

Workaround for #110.
Fixes #127.

  • migrate UI to TSF

  • implement interface for UI-less mode

  • sync style and configure between frontend and backend

@nameoverflow
Copy link
Member Author

nameoverflow commented Mar 25, 2018 •
edited
Loading

So how to clear CI boost cache?
CI failed since these changes require an additional boost library...

@Prcuvu Prcuvu requested a review from lotem March 25, 2018 16:26
@nameoverflow
Copy link
Member Author

nameoverflow commented Mar 26, 2018 •
edited
Loading

@lotem
Is there a way to detect RIME config changes? I wanna do some synchronizing between front-end and server only when necessary.

@nameoverflow nameoverflow changed the title feat: display UI in text service, support UI-less mode feat: migrate UI to text service, support UI-less mode Mar 26, 2018
@lotem
Copy link
Member

lotem commented Mar 26, 2018

@nameoverflow Configuration only changes at each deployment. Maybe we can load settings to the frontend only once for a continuous Rime session.

@nameoverflow nameoverflow force-pushed the frontend branch 3 times, most recently from 922a7f9 to 1f37c6f Compare March 27, 2018 12:49
@nameoverflow
Copy link
Member Author

nameoverflow commented Mar 27, 2018 •
edited
Loading

Looks fine now.
May need more tests.

@nameoverflow nameoverflow changed the title feat: migrate UI to text service, support UI-less mode feat(tsf): accomplish candidate UI interfaces Mar 31, 2018
@nameoverflow nameoverflow merged commit 1f0ae79 into rime:master Mar 31, 2018
@nameoverflow nameoverflow deleted the frontend branch April 1, 2018 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lotem lotem Awaiting requested review from lotem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nameoverflow @lotem @Prcuvu