Skip to content

Conversation

@WhiredPlanck
Copy link
Contributor

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #N/A

Feature

Describe feature of pull request

Improve CMake scripts composing

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

Also change the condition: only not to install on Android since Android doesn't support pkgconfig yet.
Also rename option BUILD_STATIC to WITH_STATIC_DEPS to make people more aware of its role
@WhiredPlanck WhiredPlanck force-pushed the cmake branch 4 times, most recently from d8aa71b to b5d4a0c Compare October 30, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant