Merge request for Group 4 [Winter 2024] (#49)

rilling · Feb 17, 2024 · c64eb44 · c64eb44
2 parents bdec9f1 + 8cb55c9
commit c64eb44
Show file tree

Hide file tree

Showing 2 changed files with 213 additions and 211 deletions.
diff --git a/src/main/java/de/dennisguse/opentracks/chart/ChartFragment.java b/src/main/java/de/dennisguse/opentracks/chart/ChartFragment.java
@@ -88,7 +88,7 @@ public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, Strin
             }
             if (PreferencesUtils.isKey(R.string.stats_rate_key, key)) {
                 boolean reportSpeed = PreferencesUtils.isReportSpeed(activityTypeLocalized);
-                if (reportSpeed != viewBinding.chartView.getReportSpeed()) {
+                if (reportSpeed != viewBinding.chartView.isReportSpeed()) {
                     viewBinding.chartView.setReportSpeed(reportSpeed);
                     viewBinding.chartView.applyReportSpeed();
 
@@ -105,17 +105,14 @@ public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, Strin
     /**
      * A runnable that will setFrequency the orange pointer as appropriate and redraw.
      */
-    private final Runnable updateChart = new Runnable() {
-        @Override
-        public void run() {
+    private final Runnable updateChart = ()->{
             if (!isResumed()) {
                 return;
             }
 
             viewBinding.chartView.setShowPointer(isSelectedTrackRecording());
             viewBinding.chartView.invalidate();
-        }
-    };
+        };
 
 
     @Override
@@ -166,7 +163,7 @@ public void onTrackUpdated(Track track) {
 
             activityTypeLocalized = track.getActivityTypeLocalized();
             boolean reportSpeed = PreferencesUtils.isReportSpeed(activityTypeLocalized);
-            if (reportSpeed != viewBinding.chartView.getReportSpeed()) {
+            if (reportSpeed != viewBinding.chartView.isReportSpeed()) {
                 viewBinding.chartView.setReportSpeed(reportSpeed);
                 viewBinding.chartView.applyReportSpeed();
             }
@@ -257,7 +254,7 @@ private synchronized void pauseTrackDataHub() {
      * Returns true if the selected track is recording.
      * Needs to be synchronized because trackDataHub can be accessed by multiple threads.
      */
-    @Deprecated
+    @Deprecated(since = "verision x.x",forRemoval = true)
     //TODO Should not be dynamic but instead set while instantiating, i.e., newFragment().
     private synchronized boolean isSelectedTrackRecording() {
         return trackDataHub != null && trackDataHub.isSelectedTrackRecording();