Skip to content

nit: Status Page, public url UI fixes#8920

Open
royendo wants to merge 11 commits intomainfrom
table-ui-fixes
Open

nit: Status Page, public url UI fixes#8920
royendo wants to merge 11 commits intomainfrom
table-ui-fixes

Conversation

@royendo
Copy link
Contributor

@royendo royendo commented Feb 24, 2026

  • Fix layout overflow for Search, filter dropdowns, and action buttons on the Status page tabs (Resources, Tables, Logs)
  • Rename "Clear filters" to "Clear" across all Status page tabs
  • Rename "All" to "All Types" in the Tables type filter
  • Make "Refresh all sources and models" button text responsive
  • Show only the version number (e.g., v0.82.0) in the Deployment section instead of the full build string
  • Redesign "Connect to GitHub" dialog to use underline tabs instead of a Select dropdown (fixes broken dropdown positioning inside dialogs)
  • Add placeholder text to GitHub connection Select dropdowns
  • Update Public URLs table: match search bar styling to env vars page, add horizontal scroll for narrow viewports
  • Fix settings layout overflow-hidden clipping scrollable table content (min-w-0 on slot wrapper)

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Developed in collaboration with Claude Code

@royendo royendo changed the title nit: Status Page fixes nit: Status Page, public url UI fixes Feb 24, 2026
royendo and others added 3 commits February 24, 2026 12:25
@royendo royendo requested a review from ericpgreen2 February 24, 2026 19:41
@royendo royendo marked this pull request as ready for review February 24, 2026 19:41
@royendo
Copy link
Contributor Author

royendo commented Feb 24, 2026

synced with @Di7design and @ericokuma on SKO

Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall: Well-structured UI polish PR. The changes are consistent across the Status page tabs, and the GitHub dialog redesign is a clear improvement — tabs are more appropriate than a dropdown for two options.

Issues

  1. retainValueOnMount only on Logs, not on Resources or Tables (ProjectLogsPage.svelte:249)
    The Logs Search gets retainValueOnMount but the identical Search wrappers in ProjectResources.svelte and ProjectTables.svelte do not. Is this intentional, or should it be consistent across all three tabs?

  2. Version string parsing is fragile (DeploymentSection.svelte:47)

    $: version = $runtimeVersionQuery.data?.version?.split(" ")[0] ?? "";

    This assumes the version number is always the first space-delimited token. If the format ever changes (e.g., a prefix is added), this will silently show the wrong value. A regex like /v[\d.]+/ would be more resilient, though this is minor given the format is likely stable.

  3. Dropdown trigger buttons lack min-h-9 in Logs tab (ProjectLogsPage.svelte:255)
    The Resources tab adds min-h-9 to its dropdown triggers for consistent height, but the Logs tab's filter dropdown trigger does not get the same treatment. This could cause a subtle height mismatch between tabs.

Nitpicks

  1. branch and subpath added to initialValues but only used in the "existing" tab (GithubConnectionDialog.svelte:58-59)
    These fields are always initialized (even in the "new" tab). Harmless since they're empty strings and the form only reads them when activeTab === "existing", but submitting the "new" tab form will include these empty fields in form.data.

  2. "Connect to GitHub" button lost responsive text (GithubConnectionDialog.svelte:166)
    The old code showed "Connect" on narrow viewports and "Connect to GitHub" on wide ones. The new code always shows "Connect to GitHub". Intentional? On very narrow screens this could cause overflow.


Developed in collaboration with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants