Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
synced with @Di7design and @ericokuma on SKO |
ericpgreen2
left a comment
There was a problem hiding this comment.
Overall: Well-structured UI polish PR. The changes are consistent across the Status page tabs, and the GitHub dialog redesign is a clear improvement — tabs are more appropriate than a dropdown for two options.
Issues
-
retainValueOnMountonly on Logs, not on Resources or Tables (ProjectLogsPage.svelte:249)
The Logs Search getsretainValueOnMountbut the identical Search wrappers inProjectResources.svelteandProjectTables.sveltedo not. Is this intentional, or should it be consistent across all three tabs? -
Version string parsing is fragile (
DeploymentSection.svelte:47)$: version = $runtimeVersionQuery.data?.version?.split(" ")[0] ?? "";
This assumes the version number is always the first space-delimited token. If the format ever changes (e.g., a prefix is added), this will silently show the wrong value. A regex like
/v[\d.]+/would be more resilient, though this is minor given the format is likely stable. -
Dropdown trigger buttons lack
min-h-9in Logs tab (ProjectLogsPage.svelte:255)
The Resources tab addsmin-h-9to its dropdown triggers for consistent height, but the Logs tab's filter dropdown trigger does not get the same treatment. This could cause a subtle height mismatch between tabs.
Nitpicks
-
branchandsubpathadded toinitialValuesbut only used in the "existing" tab (GithubConnectionDialog.svelte:58-59)
These fields are always initialized (even in the "new" tab). Harmless since they're empty strings and the form only reads them whenactiveTab === "existing", but submitting the "new" tab form will include these empty fields inform.data. -
"Connect to GitHub" button lost responsive text (
GithubConnectionDialog.svelte:166)
The old code showed "Connect" on narrow viewports and "Connect to GitHub" on wide ones. The new code always shows "Connect to GitHub". Intentional? On very narrow screens this could cause overflow.
Developed in collaboration with Claude Code
v0.82.0) in the Deployment section instead of the full build stringoverflow-hiddenclipping scrollable table content (min-w-0on slot wrapper)Checklist:
Developed in collaboration with Claude Code