Draft
Conversation
…r lock - Add edit session feature in web-admin with iframe-based Rill Developer embed - Add "Edit" tab to ProjectTabs (gated on `manageDev` permission) - Add `/<org>/<project>/-/edit/` route for the edit session view - Add single-editor lock in `CreateDeployment` to prevent concurrent edit sessions - Edit session auto-creates a dev deployment, polls for readiness, fetches credentials, and embeds web-local in an iframe - Toolbar provides "Push to production" (git push) and "End session" (teardown) - Timeout warning banner shown 10 minutes before session expiry
- Create workspace routing abstraction (`workspaceRoutePrefix` store) so shared web-common components build correct paths in both web-local and web-admin edit sessions - Extract `WorkspaceDispatcher` component (resource kind to workspace mapping) from web-local into web-common for reuse - Update ~15 web-common navigation/file-explorer files to use routing helpers instead of hardcoded paths - Add SvelteKit routes for edit session: files, explore, canvas - Refactor edit layout to render Navigation sidebar + WorkspaceDispatcher instead of iframe - Skip parent RuntimeProvider on edit routes to prevent runtime store conflicts between production and dev deployment credentials - Fix concurrent map write crash in `auth/claims.go` (copy Attrs map instead of mutating shared instance) - Add `ReadInstance` permission to dev deployment JWTs so Data Explorer works - Fix `ProjectGlobalStatusIndicator` crash from dev deployment response shape - Defer file content fetch until runtime credentials are available (fixes 404 on full page refresh)
ericpgreen2
changed the title
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an MVP / work-in-progress. Not ready for production. Sharing for visibility.
Cloud editing lets users edit Rill projects directly in the browser. Clicking "Edit" on a project spins up a dev deployment, and the user gets the same file explorer, code editor, and workspace views they'd see in Rill Developer — but running in the cloud.
What's here:
CreateDevDeploymentAPIEditSessionToolbarwith "Push to production" (git commit + push) and "End session" (teardown)EditSessionTimeoutBannerwarns on approaching inactivity timeoutworkspaceRoutePrefixstore lets sharedweb-commoncomponents build correct paths in bothweb-local(/files/...) andweb-admin(/<org>/<project>/-/edit/files/...)WorkspaceDispatcherextracted fromweb-localintoweb-commonfor reusefiles/,explore/,canvas/under the edit route groupNavigationsidebar + workspace views directly (no iframe)RuntimeProviderskipped on edit routes to avoid runtime store conflictsauth/claims.goReadInstancepermission added to dev deployment JWTs for Data ExplorerKnown gaps / not yet implemented:
workspaceRouteyet (~10 files deferred)Checklist:
Developed in collaboration with Claude Code