Open
Conversation
Add Oracle connector integration tests Test infrastructure: - Add Oracle testcontainer (gvenzl/oracle-free:slim-faststart) to testruntime/connectors.go - Add oracle_init_data.sql with comprehensive Oracle data types (NUMBER, BINARY_FLOAT, BINARY_DOUBLE, INTEGER, VARCHAR2, NVARCHAR2, CHAR, CLOB, BLOB, RAW, DATE, TIMESTAMP, TIMESTAMP WITH TIME ZONE, JSON) OLAP integration tests (runtime/drivers/oracle/olap_test.go): - MapScan: NUMBER, BINARY_FLOAT, BINARY_DOUBLE, INTEGER, VARCHAR2 columns - Empty rows with schema verification - NULL value handling - Numeric types (NUMBER, BINARY_FLOAT, BINARY_DOUBLE, INTEGER, SMALLINT) - String types (VARCHAR2, NVARCHAR2, CHAR, CLOB) - Timestamp types (DATE, TIMESTAMP, TIMESTAMP WITH TIME ZONE) - Dry run (EXPLAIN PLAN FOR) - Information schema Lookup - Exec (CREATE TABLE, INSERT, SELECT, DROP) - DDL retrieval via DBMS_METADATA (tables and views) Model executor test (runtime/drivers/duckdb/model_executor_sqlstore_self_oracle_test.go): - Oracle → DuckDB data transfer via warehouse interface - Verifies row count after transfer Resolver integration test (runtime/resolvers/testdata/connector_oracle.yaml): - Oracle → DuckDB materialization with column type and row count verification Results: - Oracle OLAP tests: 16/16 PASS (19s) - Oracle → DuckDB transfer: PASS (13s) - Existing unit tests: PASS
royendo
changed the title
royendo
changed the title
royendo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Oracle as a new connector using the pure Go
go-oradriver. Includes full backend implementation, frontend integration, documentation, and integration tests.Backend (
runtime/drivers/oracle/):EXPLAIN PLAN FOR, typed scan destinationsALL_TABLES,ALL_VIEWS,ALL_TAB_COLUMNSFrontend:
Integration tests:
gvenzl/oracle-free:slim-faststart) intestruntime/connectors.goChecklist: