feat: connectrpc and runtime context poc#8603
Draft
briangregoryholmes wants to merge 1 commit intomainfrom
Draft
feat: connectrpc and runtime context poc#8603briangregoryholmes wants to merge 1 commit intomainfrom
briangregoryholmes wants to merge 1 commit intomainfrom
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a rough demonstration of the structure necessary to move from Orval to connectrpc and, in turn, refactor our runtime context following the exploration in the discussion here: #8590.
For illustrative purposes, this PR specifically replaces the
metricsViewAggregationandmetricsViewTimeSeriesqueries used in theLeaderboardandMetricsTimeSeriesChartcomponents respectively, highlighting usage of the suggested pattern both inside and outside of components.Non-exhaustive to do list:
ProjectProviderand into a load function