Don't log request cancellation as internal errors in the Github APIs #5976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjain1
approved these changes
Oct 25, 2024
begelundmuller
deleted the
begelundmuller/github-apis-avoid-internal-err-on-cancel
branch
AdityaHegde
pushed a commit
that referenced
this pull request
Oct 28, 2024
AdityaHegde
added a commit
that referenced
this pull request
Oct 28, 2024
* Add basic plan info * Add actions for switching plans * Add payment section * Use new APIs * Add banners for trial and billing issues * Improve trial end math * Add TRIAL_ENDING_SOON state * Remove TRIAL_ENDING_SOON * Add plan pill * Add start team plan variants * Handle payment issues * Handle some edge cases * Open stripe page before plan upgrade * Use billing issue to show trial dates * Avoid using ListPlans API * Add null checks * Fix trial grace period end check * Handle cancelled subscriptions * UXQA fixes - pass 1 * Use RenewBillingSubscription * Handle no subscription case * Always fetch stripe page * Embed Orb customer portal * Open upgrader in same page * Tweaks * Fix misc issues * UXQA - Pass 2 * Handle viewer cases * Refactor to use billing issues message in hibernating message * Support PAYMENT_FAILED_ISSUE * Add wake all projects * UXQA - Pass 3 * Hibernating message improvements * Fix hibernate sub cancel check * minor changes (#5890) * Revert asset deletion * UXQA - Pass 4 * Add back quotas * Hardcode plan names * Add CTAs to existing email formats * UI Review comments * PR comments pass 2 * Fix upgrade callback url to stripe * PR comments pass 3 * Styling updates * Add spinner to iframe loading * Add POC plan support * Tweaks * PR comments pass 4 * fix start trial race condition (#5971) * web-auth: use svelte and vite-plugin-singlefile (#5965) * use svelte and vite-plugin-singlefile * cleanup * revert * more cleanup * regen package-lock * Share Project Popover (#5887) * wip * project share initial work * apply avatar circle list to project share * square * user invite org and group * spacing * scrollable users * user invite user set role * user invite group set role * copy * ability to remove user * do not allow current user to remove themselves * ability to remove user group * use invite group tooltip * prop rename * one more * rename * wip tooltip * use popover * add tooltip to org users * polish user email addition exp * copy * comments * lint * no prop drilling * lint * lint * clean up some org groups * feedback * feedback complete * comment out org groups * clean up avatar list item * lint * move avatar list item to avatar dir * defensive * lint * move avatar list item to features users * everyone from text * cursor tweaks * disable role change for current user * hide all users from groups * apply selected to user invite button * comment out manage org members, org set role changes * rebase fix * apply user photo url to popover * default null photo url * apply other photo urls in avatar * spacing set role margin right * support everyone at all-users * use all-users members * lint * wip * lint * multiple access tooltip * remove unused * Revert "multiple access tooltip" This reverts commit 0f62db8. * popover rename * clean up * remove unused * user-management rename * feedback * feedback * lint * defensive * use found all users group * disable preview button when explore resource is reconciling (#5962) * disable preview button when explore resource is reconciling * update tooltip * fix: display null values with italics in TDD (#5945) * display null values with italics * remove log * completely remove org from orb and stripe (#5955) * Don't log request cancellation as internal errors in the Github APIs (#5976) * trigger org repair manually (#5936) * trigger org repair manually * review comments * fix billing cust id, raise issues when updating stripe customer manually * disallow renewal to non public plan * Fix public URLs * Fix upgrade emails * Fix lint * PR comments pass 5 * check org billing init in start trial job (#5983) * Add back commented email --------- Co-authored-by: Parag Jain <pjain1@apache.org> Co-authored-by: Brian Holmes <120223836+briangregoryholmes@users.noreply.github.com> Co-authored-by: Cyrus Goh <hello@cyrusgoh.com> Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.