Runtime : health check rpc api #5185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begelundmuller
requested changes
Jul 4, 2024
Comment on lines
+116
to
+119
| // Ping implements drivers.Handle. | ||
| func (c *Connection) Ping(ctx context.Context) error { | ||
| return drivers.ErrNotImplemented | ||
| } |
There was a problem hiding this comment.
Can we return nil from these instead when they are not implemented? Returning an error will make it seem like the ping failed (e.g. if we start using the pings elsewhere).
There was a problem hiding this comment.
But if we return nil then it means HealthCheck is implemented and the connection is healthy which in this case is not.
Once we start using these Pings we should actually implement this.
| for k := range c.singleflight { | ||
| e := c.entries[k] | ||
| if c.opts.OpenTimeout != 0 && e.status == entryStatusOpening && time.Since(e.since) > c.opts.OpenTimeout { | ||
| hangingConnErr = fmt.Errorf("a connection has been in opening state for too long") |
There was a problem hiding this comment.
Could we also incorporate the connection driver name here like in the other error message?
There was a problem hiding this comment.
The handle will not be populated if the connection is in entryStatusOpening state. I could not think of any other way to get the driver name.
begelundmuller
approved these changes
Jul 4, 2024
Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.