Ensure consistent query keys for runtimeServiceListFiles #4732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Agree with all this. Nice complement to this PR – CC @AdityaHegde, there's just a little bit of overlap.
k-anshul
pushed a commit
that referenced
this pull request
Apr 30, 2024
* initial commit * revert * revert type annotation * revert bits downgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of a glob parameter from calls to
runtimeServiceListFilesto ensure that all uses of that query have the same key. Among the many issues we have with invalidation, the existence of multiple independent calls to list files meant that that they were either 1) not being invalidated when they should have been or 2) firing redundant queries for the same underlying data.This is a somewhat speculative PR and it's possible I've missed something about the need for the glob parameter.