Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable strictNullChecks at root of repo, exempting targeted folders #3442

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

bcolloran
Copy link
Contributor

@bcolloran bcolloran commented Nov 9, 2023

Expands strict null checks in the repo and limits exemptions to certain folders.

This PR only cleans up a few additional files, but will prevent future null check violations outside of the specified folders

@bcolloran bcolloran changed the title limit strictNullChecks=false to just two folders within web-common/src/features enable strictNullChecks at root of repo, exempting targeted folders Nov 9, 2023
@bcolloran bcolloran requested a review from ericpgreen2 November 9, 2023 21:19
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@ericpgreen2 ericpgreen2 merged commit 52d519c into main Nov 10, 2023
@ericpgreen2 ericpgreen2 deleted the more-null-checks branch November 10, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants