Add cli flag to enable structured logging #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enable-structured-logging
begelundmuller
requested changes
Jan 12, 2023
There was a problem hiding this comment.
- In
local, make logFormat an enum (unless you can think of a better approach to not pass the strings around – maybezaphas some types we could use?):
type LogFormat string
const (
LogFormatColor = "color"
LogFormatJSON = "json"
)
func ParseLogFormat(format string) (LogFormat, bool) {
// ...- Use
ParseLogFormatforrill start. For the other commands, just always passlocal.LogFormatColor.
This doesn't really belong in the local package, but let's not move logger management to a separate package now.
begelundmuller
requested changes
Jan 15, 2023
begelundmuller
approved these changes
Jan 17, 2023
begelundmuller
deleted the
1596-add-cli-flag-to-enable-structured-logging
branch
bcolloran
pushed a commit
that referenced
this pull request
Mar 7, 2023
* add logging format flag to cli * adding enum for log format * review changes * Review Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com>
djbarnwal
pushed a commit
that referenced
this pull request
Aug 3, 2023
* add logging format flag to cli * adding enum for log format * review changes * Review Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.