Skip to content

Commit

Permalink
E2E svelte labels (#6322)
Browse files Browse the repository at this point in the history
* Adding Refresh Model and Refresh Incremental Model labels

* label RD Export button.

In RD, due to if statement, label not being define on button.

ModelRefreshButton[label] -> ExportMenu[label] -> ToolTip
Not sure why its label vs aria-label though

* prettified, is that a word?
  • Loading branch information
royendo authored Jan 2, 2025
1 parent c17f387 commit f51d8a4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion web-common/src/features/exports/ExportMenu.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
<DropdownMenu.Trigger asChild let:builder>
{#if workspace}
<Tooltip distance={8} suppress={open}>
<Button {disabled} type="secondary" builders={[builder]} square>
<Button {label} {disabled} type="secondary" builders={[builder]} square>
<Export size="15px" />
</Button>
<TooltipContent slot="tooltip-content">Export model</TooltipContent>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
type="secondary"
builders={[builder]}
disabled={!isModelIdle || hasUnsavedChanges}
label="Refresh Incremental Model"
>
<RefreshIcon size="14px" />
</Button>
Expand Down Expand Up @@ -67,6 +68,7 @@
square
disabled={hasUnsavedChanges}
type="secondary"
label="Refresh Model"
on:click={() => refreshModel(true)}
>
<RefreshIcon size="14px" />
Expand Down

1 comment on commit f51d8a4

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.