enhancement: button presses feel more realistic

[ericlewis]

This PR adds specific down and up haptic feedback where supported, on iOS 13 and above it has an ultra-realistic feel.

This was brought up here: rileytestut/Delta#57

[hulilikii]

Feels off on the up feedback. I tried using UISelectionFeedbackGenerator similar to mame4ios and it feel just like a controller button pressing down.

Line33
private var upFeedbackGenerator: UISelectionFeedbackGenerator?

Line 51-56
if #available(iOS 13.0, *) { self.downFeedbackGenerator = UIImpactFeedbackGenerator(style: .rigid) self.upFeedbackGenerator = UISelectionFeedbackGenerator() } else { self.downFeedbackGenerator = UIImpactFeedbackGenerator(style: .medium) self.upFeedbackGenerator = UISelectionFeedbackGenerator()

Line 167
case .feedbackGenerator: self.upFeedbackGenerator?.selectionChanged()

Just some small changes to what you did.

[ericlewis]

@hulilikii what version of iOS did you try it on? I agree it felt a little heavier on pre-iOS 13 systems. But the selection felt quite unrealistic to me when compared to pressing actual gameboy buttons (I tried on real GBA system & GBC)

[hulilikii]

iOS 14.2 on 11 Pro. The soft haptic does vibrate my entire phone very lightly compared to the selection haptic being a gentle click back feeling (I do feel like the soft haptic is just perfect for those that need feedback on analog stick, feels like it rocking). Compared to what I remember from my new Game boys back in the 90s and the one I am testing now (practically unused) the button presses are firm and crisp. I don't have access to north american used models, but everyone seems to think they are quite a bit more mushy and easy to press? This maybe why our feelings differ?
I don't mean to argue the point, I just think the time and testing the mame4ios devs put into this button response is just right for most users (less haptics is usually better to start with).

[lonkelle]

Reopening this @ericlewis because iOS 15s default controller has your style of haptic feedback so since we now support that, I can see needing this in the future to simulate the same experience for our default skins.