Skip to content

Commit

Permalink
mvc - replace Phalcon\Filter\Validation\Validator\Regex with new nati…
Browse files Browse the repository at this point in the history
…ve OPNsense\Base\Validators\Regex validator

for opnsense#6389
  • Loading branch information
AdSchellevis committed May 1, 2024
1 parent b10c17f commit 9ab0edb
Show file tree
Hide file tree
Showing 5 changed files with 70 additions and 5 deletions.
1 change: 1 addition & 0 deletions plist
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,7 @@
/usr/local/opnsense/mvc/app/models/OPNsense/Base/Validators/NetworkValidator.php
/usr/local/opnsense/mvc/app/models/OPNsense/Base/Validators/Numericality.php
/usr/local/opnsense/mvc/app/models/OPNsense/Base/Validators/PresenceOf.php
/usr/local/opnsense/mvc/app/models/OPNsense/Base/Validators/Regex.php
/usr/local/opnsense/mvc/app/models/OPNsense/CaptivePortal/ACL/ACL.xml
/usr/local/opnsense/mvc/app/models/OPNsense/CaptivePortal/CaptivePortal.php
/usr/local/opnsense/mvc/app/models/OPNsense/CaptivePortal/CaptivePortal.xml
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

namespace OPNsense\Base\FieldTypes;

use Phalcon\Filter\Validation\Validator\Regex;
use OPNsense\Base\Validators\Regex;

/**
* Class TextField
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

namespace OPNsense\Base\FieldTypes;

use Phalcon\Filter\Validation\Validator\Regex;
use OPNsense\Base\Validators\Regex;


/**
Expand Down
64 changes: 64 additions & 0 deletions src/opnsense/mvc/app/models/OPNsense/Base/Validators/Regex.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
<?php

/**
* Copyright (C) 2024 Deciso B.V.
*
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
*
* 1. Redistributions of source code must retain the above copyright notice,
* this list of conditions and the following disclaimer.
*
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES,
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY
* AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
* AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
* OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
*
*/

namespace OPNsense\Base\Validators;

use OPNsense\Base\BaseValidator;
use OPNsense\Base\Messages\Message;

/**
* @package OPNsense\Base\Validators
*/
class Regex extends BaseValidator
{
/**
* Executes validation
*
* @param $validator
* @param string $attribute
* @return boolean
*/
public function validate($validator, $attribute): bool
{
$value = $validator->getValue($attribute);
$pattern = $this->getOption('pattern');
$msg = $this->getOption('message');
$failed = true;
if ($value !== null && preg_match($pattern, $value, $matches) ) {
$failed = $matches[0] != $value;
}
if ($failed) {
$validator->appendMessage(new Message($msg, $attribute, 'Regex'));
return false;
}

return true;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ public function testValueWithMask()
$field->setMask('/^[a-z]{8}$/');
$field->setValue("4bcd3fgh");

$this->assertContains('Phalcon\Filter\Validation\Validator\Regex', $this->validate($field));
$this->assertContains('Regex', $this->validate($field));
}

/**
Expand Down Expand Up @@ -243,7 +243,7 @@ public function testIntegerValueWithMaskFail()
$field->setValue(1234);

$this->assertEquals($field->getNodeData(), "1234");
$this->assertContains('Phalcon\Filter\Validation\Validator\Regex', $this->validate($field));
$this->assertContains('Regex', $this->validate($field));
}

/**
Expand Down Expand Up @@ -341,6 +341,6 @@ public function testValueChangeCaseUpperWithMaskFail()
$field->setChangeCase('UPPER');
$field->setValue("ab cde fgh");

$this->assertContains('Phalcon\Filter\Validation\Validator\Regex', $this->validate($field));
$this->assertContains('Regex', $this->validate($field));
}
}

0 comments on commit 9ab0edb

Please sign in to comment.