Skip to content

Comments

Auto-accept oh-my-zsh update prompt#167

Merged
rikuson merged 1 commit intomasterfrom
salsilla-homemaking
Feb 17, 2026
Merged

Auto-accept oh-my-zsh update prompt#167
rikuson merged 1 commit intomasterfrom
salsilla-homemaking

Conversation

@rikuson
Copy link
Owner

@rikuson rikuson commented Feb 17, 2026

Summary

  • Add DISABLE_UPDATE_PROMPT=true to .zshrc so oh-my-zsh updates automatically without prompting

Test plan

  • Open a new terminal session and verify no update prompt appears
  • Confirm oh-my-zsh auto-updates when a new version is available

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@claude
Copy link

claude bot commented Feb 17, 2026

Code Review

Summary

This PR adds DISABLE_UPDATE_PROMPT=true to the .zshrc configuration to enable automatic oh-my-zsh updates without user prompts.

✅ Strengths

  1. Clean implementation: The change is minimal and correctly placed before sourcing oh-my-zsh (line 22-23)
  2. Valid oh-my-zsh setting: DISABLE_UPDATE_PROMPT is a documented oh-my-zsh environment variable that enables automatic updates
  3. Consistent with automation goals: Aligns well with the repository's purpose of automated workspace provisioning
  4. Proper location: Added within the oh-my-zsh conditional block where other oh-my-zsh settings live

💡 Considerations

  1. Behavior clarification: The variable name might be slightly misleading:

    • DISABLE_UPDATE_PROMPT=true doesn't disable updates entirely
    • It disables the prompt and enables automatic updates
    • Updates still happen, just without user confirmation
  2. Alternative approach: If you want to disable updates completely (which may be preferable for reproducibility), consider using DISABLE_AUTO_UPDATE=true instead

  3. Documentation: The current behavior is clear from the PR description, but you might want to add an inline comment in the .zshrc file for future reference:

    # Auto-update oh-my-zsh without prompting
    DISABLE_UPDATE_PROMPT=true

🔒 Security & Best Practices

  • Security: ✅ No security concerns. Automatic updates generally improve security by keeping oh-my-zsh current with patches
  • Performance: ✅ No performance impact
  • Test coverage: The test plan in the PR description is reasonable, though manual
  • Code quality: ✅ Follows existing formatting and structure

📋 Recommendation

LGTM with minor suggestion: The implementation is correct and safe. Consider adding an inline comment for clarity, but this is optional. The change achieves the stated goal effectively.

Question for consideration: Do you prefer automatic updates (current approach) or completely disabled updates for reproducibility? Both are valid choices depending on your workflow preferences.

@rikuson rikuson force-pushed the salsilla-homemaking branch from 3e3fae8 to fda6420 Compare February 17, 2026 00:40
@rikuson rikuson enabled auto-merge (squash) February 17, 2026 00:41
@rikuson rikuson merged commit cf50be0 into master Feb 17, 2026
5 checks passed
@rikuson rikuson deleted the salsilla-homemaking branch February 17, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant