Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves issue #101 #102

Closed
wants to merge 1 commit into from
Closed

resolves issue #101 #102

wants to merge 1 commit into from

Conversation

Lemon2311
Copy link

I changed the fitties variable from an array to a WeakSet, resolves issue #101

@rikschennink
Copy link
Owner

Thanks I will take a look at it when I have some time.

@chrisjansky
Copy link

Looking at the changes, it seems the code would not work — WeakSet is not iterable by design so all those Array.from(...) calls would break. Am I missing something @Lemon2311 ?

@Lemon2311 Lemon2311 closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lemon2311 @rikschennink @chrisjansky