Skip to content

Add element parameter to onStart and onDone callbacks #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2018
Merged

Add element parameter to onStart and onDone callbacks #79

merged 2 commits into from
Mar 10, 2018

Conversation

jgmcelwain
Copy link
Contributor

I ran into a situation where I wanted to add a class to an element after it had been scrolled to. Adding the element as a param of the onStart and onDone callback feels like a good way to make this possible.

@rigor789
Copy link
Owner

Sure why not, but i would add it to the onCancel callback as a second parameter as well, can you add it or do you want me to do it after I merge this?

@rigor789
Copy link
Owner

Perfect! Thanks 👍

@rigor789 rigor789 merged commit 405a1e8 into rigor789:master Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants