Skip to content

Updating scroll-to to have events #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DanWithams7d
Copy link

Adding event to allow preventDefault to be called and alter the flow of the event.

Adding event to allow preventDefault to be called and alter the flow of the event.
@DanWithams7d
Copy link
Author

@rigor789 Not sure if you've seen this PR? Please let me know if you want anything changed?

@rigor789
Copy link
Owner

rigor789 commented May 30, 2019

@DanWithams7d Hey! Sorry for the long delay - I've been really busy lately and had no time to check out this yet! I haven't forgotten about it though, and will try to take a look in the next few days (changes look ok - but will have to release it - which takes some time)!

@DanWithams7d
Copy link
Author

Thanks very much! :)

@rigor789
Copy link
Owner

Hey @DanWithams7d!

I just got around to fixing/merging PRs for this repo. I just checked this, and I am wondering about the motivation behind this change.

I'm also looking for example of how this is used, so we can update the docs accordingly if this gets merged.

Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants