feat: migrate optipy to rigetti-pyo3
#61
Conversation
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
| allow = [ "MPL-2.0",] | ||
| name = "webpki-roots" | ||
| version = "*" | ||
|
|
There was a problem hiding this comment.
The MPL-2.0 license exception for webpki-roots has been removed, but MPL-2.0 wasn't added to the general allowed licenses list. If this dependency is still used in the project, this could cause license compliance issues when running cargo deny check.
There was a problem hiding this comment.
With it in the configuration, cargo deny --workspace check gives
warning[license-exception-not-encountered]: license exception was not encountered
so it seems unneeded.
asaites
force-pushed
the
60-feat-migrate-optipy
branch
from
28194f6 to
0ef35d7
Compare
asaites
force-pushed
the
60-feat-migrate-optipy
branch
from
b57ba1c to
ebe0022
Compare
| tool: cargo-msrv,cargo-make | ||
| - run: cargo make msrv-verify | ||
| tool: cargo-msrv | ||
| - run: cargo make --cwd rigetti-pyo3 msrv-verify |
There was a problem hiding this comment.
Why not apply these to optipy as well?
|
|
||
| jobs: | ||
| prepare-release: | ||
| if: ${{ ! (github.event_name == 'push' && contains(github.event.head_commit.message, 'prepare release [skip ci]' )) }} |
There was a problem hiding this comment.
For readability, I would have preferred this, assuming it parses correctly
if: ${{ github.event_name != 'push' || ! contains(github.event.head_commit.message, 'prepare release [skip ci]' ) }}| jobs: | ||
| publish-rigetti-pyo3: |
There was a problem hiding this comment.
Wouldn't have applied at the time of the PR, but with Rust 1.90 we now have cargo publish --workspace
| same "printed page" as the copyright notice for easier | ||
| identification within third-party archives. | ||
|
|
||
| Copyright 2022 Rigetti Computing |
There was a problem hiding this comment.
Probably needs bumped to 2025
|
|
||
| ### What about stubs? | ||
|
|
||
| If you're also use `pyo3_stub_gen` to generate Python stub files, |
|
|
||
| If you're also use `pyo3_stub_gen` to generate Python stub files, | ||
| this macro strips those attributes, too, | ||
| and by default, the macro strips both attributes of both creates. |
| !(id == "pyo3" | ||
| || id == "new" | ||
| || id == "getter" | ||
| || id == "setter" | ||
| || id == "pyclass" | ||
| || id == "pymethods" | ||
| || id == "pyfunction" | ||
| || id == "pymodule" | ||
| || id == "staticmethod" | ||
| || id == "classmethod" | ||
| || id == "classattr" | ||
| || id == "args" | ||
| || id == "gen_stub") |
There was a problem hiding this comment.
Would have suggested using either
["pyo3", "new", ...].iter().all(|name| id != name)or
// array must be sorted
// returns `Err` if not found
["pyo3", "new", ...].binary_search(id).is_err()
rigetti-pyo3to a subdirectoryoptipycrateCargo,knope,Makefile.tomls, and the CI workflow to make sense with the workspaceCloses: #60