-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add documentation to all generated methods #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6e1436a to
3480712
Compare
|
I've added this documentation, which is great, but it occurs to me that there's another way: have the enum wrappers take a visibility argument and not automatically generate |
3480712 to
a2fa204
Compare
|
Also, I feel like this PR ought to come with a test but I'm not sure how to test this. I could add something that turns on |
00fde47 to
974a75e
Compare
|
This is now available for review, but I have some concerns about the tests. Not only do they depend on eupn/macrotest#115 (currently we point to anatalsz/macrotest to get it early), but we also have to play games with the very specific OS we do the expansion for, which necessitates the end user using
An alternative design would be to add a post-processing filter to |
5128a9b to
627e224
Compare
This enables easier manual testing with `cargo expand`, and will enable easier snapshot testing later.
627e224 to
f3ca274
Compare
Closes #50