Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Gates should no longer compare as equal and not equal. #1671

Merged
merged 6 commits into from
Sep 27, 2023
Merged

fix: Gates should no longer compare as equal and not equal. #1671

merged 6 commits into from
Sep 27, 2023

Conversation

MarquessV
Copy link
Contributor

Description

Closes #1665

This issue came from quil not having an explicit not equals comparison. Bumping qcs-sdk-python bumps quil to a version with the fix. Recent updates to quil should also improve the performance of adding two Program's together.

Checklist

  • The PR targets the master branch
  • The above description motivates these changes.
  • The change is atomic and can be described by a single commit (your PR will be squashed on merge).
  • All changes to code are covered via unit tests.
  • Parameters and return values have type hints with PEP 484 syntax.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.

@MarquessV MarquessV marked this pull request as ready for review September 27, 2023 22:27
@MarquessV MarquessV requested a review from a team as a code owner September 27, 2023 22:28
@rigetti-githubbot
Copy link

rigetti-githubbot commented Sep 27, 2023 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
6852 6000 88% 87% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 214be9e by action🐍

BatmanAoD
BatmanAoD approved these changes Sep 27, 2023
View reviewed changes
test/unit/test_quilbase.py Show resolved Hide resolved
@MarquessV @BatmanAoD
Update test/unit/test_quilbase.py
214be9e 
Co-authored-by: Kyle J Strand <BatmanAoD@users.noreply.github.com>
@MarquessV MarquessV merged commit fc513ea into master Sep 27, 2023
@MarquessV MarquessV deleted the update-quil branch September 27, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BatmanAoD BatmanAoD BatmanAoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gates are simultaneously equal and not equal
3 participants
@MarquessV @rigetti-githubbot @BatmanAoD