Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace retry with tenacity to resolve a dependency vulnerability #1581

Merged
merged 1 commit into from
May 24, 2023

Conversation

luigibertaco
Copy link
Contributor

Description

As mentioned in #1552, the retry dependency uses py that has a known vulnerability.

This PR replaces retry with tenacity and shouldn't introduce any practical changes to pyquil.

Checklist

  • The PR targets the master branch
  • The above description motivates these changes.
  • The change is atomic and can be described by a single commit (your PR will be squashed on merge).
  • All changes to code are covered via unit tests.

@luigibertaco luigibertaco requested a review from a team as a code owner May 23, 2023 00:40
Copy link
Contributor

@MarquessV MarquessV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for contributing to pyQuil!

@MarquessV MarquessV merged commit 662d5aa into rigetti:master May 24, 2023
@luigibertaco
Copy link
Contributor Author

Thanks for approving and merging @MarquessV

Any idea when this change will be released to a new version of pyquil?

@MarquessV
Copy link
Contributor

@luigibertaco Just published 3.5.2, which includes these changes.

@luigibertaco
Copy link
Contributor Author

Thanks for that @MarquessV
Can this change also be included on the v4 RC soon?

@MarquessV
Copy link
Contributor

Thanks for that @MarquessV Can this change also be included on the v4 RC soon?

Sure thing, I just published RC17, which includes this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants