Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Assign a fidelity of 100% to RZ operations to break symmetry with RX in ISA. #1433

Merged
merged 3 commits into from
Mar 16, 2022
Merged

Update: Assign a fidelity of 100% to RZ operations to break symmetry with RX in ISA. #1433

merged 3 commits into from
Mar 16, 2022

Conversation

axdhill
Copy link
Contributor

@axdhill axdhill commented Mar 16, 2022 •
edited
Loading

Description

Assign a fidelity of 100% to RZ operations to break symmetry with RX in ISA.

Closes #1432

Checklist

  • The PR targets the rc branch (not master).
  • The above description motivates these changes.
  • There is a unit test that covers these changes.
  • All new and existing tests pass locally and on the PR's checks.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • All code follows Black style and obeys flake8 conventions.
  • (New Feature) The docs have been updated accordingly.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.
  • The changelog is updated, including author and PR number (@username, Test ignore #1234).

@axdhill axdhill requested a review from a team as a code owner March 16, 2022 00:20
@axdhill axdhill linked an issue Mar 16, 2022 that may be closed by this pull request
RZ and RX fidelity are assumed to be equal, resulting in suboptimal ISA for compilation #1432
Closed
2 tasks
@axdhill axdhill changed the base branch from master to rc March 16, 2022 00:21
@axdhill axdhill force-pushed the 1432-rz-and-rx-fidelity-are-assumed-to-be-equal-resulting-in-suboptimal-isa-for-compilation branch from 08755bd to 4446a6a Compare March 16, 2022 00:27
@axdhill axdhill force-pushed the 1432-rz-and-rx-fidelity-are-assumed-to-be-equal-resulting-in-suboptimal-isa-for-compilation branch from a89df0c to ae93a30 Compare March 16, 2022 00:56
@dbanty dbanty mentioned this pull request Mar 16, 2022
Closed
dbanty
dbanty approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@dbanty dbanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dbanty dbanty changed the title Assign a fidelity of 100% to RZ operations to break symmetry with RX … Update: Assign a fidelity of 100% to RZ operations to break symmetry with RX in ISA. Mar 16, 2022
@dbanty dbanty merged commit 76785c0 into rc Mar 16, 2022
@dbanty dbanty deleted the 1432-rz-and-rx-fidelity-are-assumed-to-be-equal-resulting-in-suboptimal-isa-for-compilation branch March 16, 2022 21:41
@rigetti-githubbot
Copy link

🎉 This PR is included in version 3.2.0-rc.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rigetti-githubbot
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmgsk notmgsk notmgsk approved these changes

@dbanty dbanty dbanty approved these changes

Assignees
No one assigned
Labels
released on @rc released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RZ and RX fidelity are assumed to be equal, resulting in suboptimal ISA for compilation
4 participants
@axdhill @rigetti-githubbot @notmgsk @dbanty