Fix: #1417 DefFrame to/from Quil with JSON values #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@notmgsk This is ready for a look when you're up. |
dbanty
reviewed
Feb 9, 2022
notmgsk
reviewed
Feb 9, 2022
| assert ( | ||
| fdef.out() | ||
| == r"""DEFFRAME My-Cool-Qubit "bananas": | ||
| DIRECTION: "go west" |
notmgsk
reviewed
Feb 9, 2022
| @@ -60,7 +60,7 @@ def_circuit : "DEFCIRCUIT" name [ variables ] [ qubit_designators ] ":" indented | |||
| // | "DEFCIRCUIT" name [ variables ] qubit_designators ":" indented_instrs -> def_circuit_qubits | |||
|
|
|||
| def_frame : "DEFFRAME" frame ( ":" frame_spec+ )? | |||
| frame_spec : _NEWLINE_TAB frame_attr ":" (expression | string ) | |||
| frame_spec : _NEWLINE_TAB frame_attr ":" ( expression | string ) | |||
There was a problem hiding this comment.
Ah, so it already was string. I must've been looking at the wrong/old branch.
There was a problem hiding this comment.
Yeah, we were looking at master, but this was already done on rc. When I got here and saw it I assumed you'd done it. :)
notmgsk
approved these changes
Feb 9, 2022
|
Hella tight. |
|
🎉 This PR is included in version 3.1.0-rc.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
dbanty
pushed a commit
that referenced
this pull request
Feb 14, 2022
* Fix: #1417 DefFrame to/from Quil with JSON values * No code: Update changelog
|
🎉 This PR is included in version 3.2.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1417, #1418
Checklist
rcbranch (notmaster).patternfield).flake8conventions.