Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow RESET instructions to pass through latex generation #1118

Merged

Conversation

braised-babbage
Copy link
Contributor

@braised-babbage braised-babbage commented Dec 3, 2019

Description

As it currently stands, programs with RESET operations are not semantically different (in an ideal world) to those without them. Actual drawing of the detailed operation of RESET (which involves a measurement and some small amount of feedback control) is a significant scope creep to this latex code. Thus I propose simply ignoring RESET instructions for the purpose of rendering circuits.

@braised-babbage braised-babbage requested a review from a team as a code owner December 3, 2019 01:55
Copy link
Contributor

@ecpeterson ecpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@braised-babbage braised-babbage force-pushed the feature/allow-RESET-to-silently-render-into-the-void branch from 1157e33 to fc64cde Compare December 13, 2019 17:15
@braised-babbage braised-babbage requested a review from a team December 13, 2019 17:17
@braised-babbage braised-babbage force-pushed the feature/allow-RESET-to-silently-render-into-the-void branch from fc64cde to 52d75a0 Compare December 13, 2019 17:30
@ecpeterson ecpeterson merged commit 1fd2ab2 into master Dec 13, 2019
@karalekas karalekas added this to the v2.15 milestone Dec 18, 2019
@karalekas karalekas added the enhancement ✨ A request for a new feature. label Dec 18, 2019
@karalekas karalekas changed the title Allow RESET instructions to silently fall through the latex generation process Allow RESET instructions to pass through latex generation Dec 20, 2019
@karalekas karalekas deleted the feature/allow-RESET-to-silently-render-into-the-void branch December 30, 2019 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ A request for a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants