Skip to content

Conversation

@Shadow53
Copy link
Contributor

No description provided.

Copy link

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤙

💡 To request another review, post a new comment with "/windsurf-review".

with:
toolchain: stable
override: true
- uses: dtolnay/rust-toolchain@stable

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust dtolnay, but what's the difference here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions-rs was archived a couple of years ago

- uses: actions/checkout@v5
with:
fetch-depth: 0
# test that PAT works

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I.e. a different token (presumably a per-job one) is used by default, but explicitly using the one from secrets ensures that when it expires, jobs will fail prior to merge?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the idea, yeah

@Shadow53 Shadow53 merged commit 538bc75 into main Sep 30, 2025
2 checks passed
@Shadow53 Shadow53 deleted the update-actions branch September 30, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants